Create shareable stylelint package for lucca-front. #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbasmaison-lucca
added
🔖✨ Feature
fbasmaison-lucca
force-pushed
the
stylelint
branch
from
3be47d0 to
9549745
Compare
Merged
1 similar comment
fbasmaison-lucca
force-pushed
the
stylelint
branch
from
81b5b75 to
a15a407
Compare
4 similar comments
1 similar comment
|
@jeremie-lucca : J’ai intégré les changements dont je t’ai parlé dans cette PR. On constate qu’il restait un Cette Issue a plus de détails, notamment sur ce que j’imagine côté front. (cc @Supamiu) Reparlons-en quand vous pourrez. :) |
… and allow having lines between @ rules with the same name, so that config files don’t become a pain.
… and allow not to have lines between variables, so that config files don’t become a pain.
… and allow some files to be empty (angular and scss components).
1 similar comment
Comment on lines
+22
to
+31
| // 'block-no-empty': null, | ||
| // 'font-family-no-missing-generic-family-keyword': null, | ||
| // 'no-descending-specificity': null, | ||
| // 'no-duplicate-selectors': null, | ||
| // 'property-no-vendor-prefix': null, | ||
| // 'scss/at-mixin-argumentless-call-parentheses': null, | ||
| // 'scss/at-mixin-pattern': null, | ||
| // 'scss/at-rule-conditional-no-parentheses': null, | ||
| // 'scss/at-rule-no-unknown': null, | ||
| // 'selector-not-notation': null, |
There was a problem hiding this comment.
The broken PR is on purpose, so that we can have a look at it together.
I commented these lines to enable default config rules for CSS and SCSS configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a shareable stylelint config package for Lucca Front.
Commits address rules with errors individually, either by ignoring them for now, or fixing them.